[EuiTable/EuiBasicTable/EuiInMemoryTable] Warn when not recommended cell/column width units are used#9540
Merged
tkajtoch merged 3 commits intoelastic:mainfrom Mar 30, 2026
Conversation
Collaborator
💚 Build SucceededHistory
cc @tkajtoch |
Collaborator
💚 Build Succeeded
cc @tkajtoch |
acstll
approved these changes
Mar 30, 2026
Contributor
acstll
left a comment
acstll
left a comment
There was a problem hiding this comment.
🟢 Tested locally in Storybook, everything working as expected. Also from the code side, looking good 👍
Comment on lines
+33
to
+35
| export const WARNING_MESSAGE_NOT_RECOMMENDED_UNIT = | ||
| 'Detected not recommended unit (%, vw, cqw, cqi) in cell width settings. Adjust the `width`, `minWidth` and `maxWidth` values to use absolute length units like `em` for text cells or `px` for static elements like icons or plots.'; | ||
|
|
Contributor
There was a problem hiding this comment.
(out of scope) it'd be nice for consumers to have a reference in the message to where it's coming from, something like "EuiTable: Detected not recommended unit…", otherwise might be a bit mysterious (i'm guessing it's not straightforward to do since the message applies to many different components)
Member
Author
There was a problem hiding this comment.
Yeah, that was exactly my thinking on this one, and I decided to leave it as-is... We should probably have a method to inform users of deprecations and other similar warnings better
weronikaolejniczak
pushed a commit
to weronikaolejniczak/eui
that referenced
this pull request
Apr 7, 2026
…ell/column width units are used (elastic#9540)
weronikaolejniczak
pushed a commit
to weronikaolejniczak/eui
that referenced
this pull request
Apr 7, 2026
…ell/column width units are used (elastic#9540)
mgadewoll
added a commit
to elastic/kibana
that referenced
this pull request
Apr 13, 2026
## Dependency updates - `@elastic/eui` - v114.0.0 ⏩ v114.1.0 - `@elastic/eslint-plugin-eui` - v2.11.0 ⏩ v2.11.1 --- ## Package updates ### @elastic/eui [`v114.1.0`](https://github.com/elastic/eui/releases/v114.1.0) - Added an optional `tooltipProps` prop to `EuiMarkdownEditorHelpButton` ([#9546](elastic/eui#9546)) - Added a warning when non-recommended units are used in `width`, `minWidth` or `maxWidth` props on `<EuiTableFooterCell>`, `<EuiTableHeaderCell>`, `<EuiTableHeaderCellCheckbox>` as well as the `columns` configuration on `<EuiBasicTable>` and `<EuiInMemoryTable>` ([#9540](elastic/eui#9540)) - Added `transitionBottomIn` and `transitionBottomOut` icons to `EuiIcon` ([#9528](elastic/eui#9528)) **Bug fixes** - Fixed `EuiFlyoutManager` animation flickering when switching between flyout sessions by removing intermediate transition stages (backgrounding, returning, closing) and limiting opening animations to the initial flyout and first child only ([#9514](elastic/eui#9514)) - Fixed rendering of `EuiTableHeaderMobile` when `responsiveBreakpoint=false` prop is set ([#9531](elastic/eui#9531)) ### @elastic/eslint-plugin-eui v2.11.1 **Bug fixes** - Fixed `no-css-color` ESLint rule crash when analyzing functions that return `undefined` or non-object values ([#9368](elastic/eui#9368)) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
michel-laterman
pushed a commit
to michel-laterman/kibana
that referenced
this pull request
Apr 13, 2026
## Dependency updates - `@elastic/eui` - v114.0.0 ⏩ v114.1.0 - `@elastic/eslint-plugin-eui` - v2.11.0 ⏩ v2.11.1 --- ## Package updates ### @elastic/eui [`v114.1.0`](https://github.com/elastic/eui/releases/v114.1.0) - Added an optional `tooltipProps` prop to `EuiMarkdownEditorHelpButton` ([elastic#9546](elastic/eui#9546)) - Added a warning when non-recommended units are used in `width`, `minWidth` or `maxWidth` props on `<EuiTableFooterCell>`, `<EuiTableHeaderCell>`, `<EuiTableHeaderCellCheckbox>` as well as the `columns` configuration on `<EuiBasicTable>` and `<EuiInMemoryTable>` ([elastic#9540](elastic/eui#9540)) - Added `transitionBottomIn` and `transitionBottomOut` icons to `EuiIcon` ([elastic#9528](elastic/eui#9528)) **Bug fixes** - Fixed `EuiFlyoutManager` animation flickering when switching between flyout sessions by removing intermediate transition stages (backgrounding, returning, closing) and limiting opening animations to the initial flyout and first child only ([elastic#9514](elastic/eui#9514)) - Fixed rendering of `EuiTableHeaderMobile` when `responsiveBreakpoint=false` prop is set ([elastic#9531](elastic/eui#9531)) ### @elastic/eslint-plugin-eui v2.11.1 **Bug fixes** - Fixed `no-css-color` ESLint rule crash when analyzing functions that return `undefined` or non-object values ([elastic#9368](elastic/eui#9368)) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
weronikaolejniczak
pushed a commit
to weronikaolejniczak/eui
that referenced
this pull request
May 5, 2026
…ell/column width units are used (elastic#9540)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #9444
This PR adds a console warning when non-recommended width units are used (
%,vw,cqi,cqw). ThisAPI Changes
No API changes
Screenshots
Deprecation notice / migration guide
Adjust all
width,minWidthandmaxWidthprop values on<EuiTableFooterCell>,<EuiTableHeaderCell>,<EuiTableHeaderCellCheckbox>as well as thecolumnsconfiguration on<EuiBasicTable>and<EuiInMemoryTable>to not use any viewport-relative length units. We recommend using thepxunit for static elements like icons or plots andemfor everything else.Impact Assessment
🔴 Breaking changes — What will break? How many usages in Kibana/Cloud UI are impacted?💅 Visual changes — May impact style overrides; could require visual testing. Explain and estimate impact.🧪 Test impact — May break functional or snapshot tests (e.g., HTML structure, class names, default values).🔧 Hard to integrate — If integration is complex, stage commits in Kibana/Cloud UI branches for cherry-picking and link to them below.Impact level: 🟢 None
Release Readiness
Documentation: {link to docs page(s)}Will be updated in [Tables sweep] Add tabular content guidelines #9527 insteadFigma: {link to Figma or issue}Adoption plan (new features): {link to issue/doc or outline who will integrate this and where}QA instructions for reviewer
width,minWidthormaxWidthprops to a value including%and confirm the warning message appears in consoleChecklist before marking Ready for Review
QA: Tested light/dark modes, high contrast, mobile, Chrome/Safari/Edge/Firefox, keyboard-only, screen readerQA: Tested in CodeSandbox and KibanaQA: Tested docs changesBreaking changes: Addedbreaking changelabel (if applicable)Reviewer checklist